Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigator: add basic history support, enable advanced focus restoration #37223

Closed
wants to merge 17 commits into from
Closed

Navigator: add basic history support, enable advanced focus restoration #37223

wants to merge 17 commits into from

Commits on Dec 14, 2021

  1. Navigator: add basic history support

    @ciampo
    ciampo committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    d700ffe View commit details
    Browse the repository at this point in the history

  2. Update Navigator usage across the repo

    @ciampo
    ciampo committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    96f1d5f View commit details
    Browse the repository at this point in the history

  3. Typo

    @ciampo
    ciampo committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    533e61f View commit details
    Browse the repository at this point in the history

  4. Rename navigationTriggerElement to focusRestorationSelector

    @ciampo
    ciampo committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    092acf5 View commit details
    Browse the repository at this point in the history

  5. Add focus restoration on navigating back

    @ciampo
    ciampo committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    7f8339f View commit details
    Browse the repository at this point in the history

  6. Update Navigator stories to work with focus restoration

    @ciampo
    ciampo committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    7b86743 View commit details
    Browse the repository at this point in the history

  7. Add focus restoration support to Preferences Modal and GLobal Styles … 

    …sidebar
    @ciampo
    ciampo committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    1a773b9 View commit details
    Browse the repository at this point in the history

  8. Add isInitial property to the location object, use it instead of … 

    …`isFirstRender` in the `NavigatorScreen`
    @ciampo
    ciampo committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    c78e792 View commit details
    Browse the repository at this point in the history

  9. Wrap push and pop in useCallback

    @ciampo
    ciampo committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    af8a6dd View commit details
    Browse the repository at this point in the history

  10. Rename focusRestorationSelector to focusTargetSelector

    @ciampo
    ciampo committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    94eb58c View commit details
    Browse the repository at this point in the history

  11. Make sure that isInitial and isBack cannot be overridden when pus… 

    …hing a new location
    @ciampo
    ciampo committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    3af4385 View commit details
    Browse the repository at this point in the history

  12. Add NavigatorLink and NavigatorBackLink, replace usages across co… 

    …debase
    @ciampo
    ciampo committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    ba08a42 View commit details
    Browse the repository at this point in the history

  13. Use id as the attribute to restore focus

    @ciampo
    ciampo committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    76e88c6 View commit details
    Browse the repository at this point in the history

  14. Add NavigatorLink and NavigatorBackLink to docs manifest

    @ciampo
    ciampo committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    8915a7c View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. Refactor to hooks

    @ciampo
    ciampo committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    38c4ed2 View commit details
    Browse the repository at this point in the history

  2. Do not expose selectorFactor prop

    @ciampo
    ciampo committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    df584de View commit details
    Browse the repository at this point in the history

  3. Use Button as detault component to render NavigatorLink and `Navi… 

    …gatorBackLink`
    @ciampo
    ciampo committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    d219320 View commit details
    Browse the repository at this point in the history