Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move WP 5.9 wp-admin menus compatibility code to lib/compat folder #37257

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

youknowriad
Copy link
Contributor

Just continues the code quality work that is similar to #37141

@youknowriad youknowriad added [Type] Code Quality Issues or PRs that relate to code quality Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Dec 9, 2021
@youknowriad youknowriad requested a review from a team December 9, 2021 13:56
@youknowriad youknowriad self-assigned this Dec 9, 2021
* @param bool $is_block_editor_screen Current decision about loading block assets.
* @return bool Filtered decision about loading block assets.
*/
function gutenberg_site_editor_load_block_editor_scripts_and_styles( $is_block_editor_screen ) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this function to this file because it's related to this screen.

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Riad. Changes look good to me.

@youknowriad youknowriad force-pushed the move/menu-compat-code branch from 6a05680 to 5d99222 Compare December 10, 2021 07:43
@youknowriad youknowriad merged commit 1b15cf1 into trunk Dec 10, 2021
@youknowriad youknowriad deleted the move/menu-compat-code branch December 10, 2021 10:39
@github-actions github-actions bot added this to the Gutenberg 12.2 milestone Dec 10, 2021
@noisysocks noisysocks removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants