Template Editing Mode: Fix options dropdown #37442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Template Editing Mode
|
Size Change: +1.99 kB (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
I don't know that we necessarily have to hide the dropdown here. For example it may be useful to view the description to better understand the currently-applied template – especially as some of them have somewhat ambiguous names. Here's the dropdown when editing the Page template in the site editor:
I'm inclined to say we should work towards consistency across editing contexts. IE display the dropdown, without any actions. |
|
Thanks for catching that. So only hide dropdown when we have nothing to display, like custom templates by theme. |
|
Yes I think so. Although it may be worth building in a condition to check for a description and display the dropdown when one exists. It seems very likely that it will be possible for custom theme templates to include descriptions in the future. |
|
I fixed the logic and added back descriptions. |
|
I'm only seeing the description.
Do you think it makes sense to include the title like in the screenshot from the Site Editor above? |
Sure. I'm all for consistency. |
|
@jameskoster started working on this, and I changed my mind 😅 I think displaying the Template title twice isn't necessary. |
|
Hah, I don't have a strong feeling but would be inclined to say we should match the Site Editor for now, and then explore this particular detail in a separate issue. I suspect we'll revise this popover soon, possibly as a part of #36951. |
|
@jameskoster sounds good. I will update the component tomorrow 👍 |
ntsekouras
reviewed
Dec 17, 2021
packages/edit-post/src/components/header/template-title/edit-template-title.js
Show resolved
Hide resolved
ntsekouras
reviewed
Dec 17, 2021
There was a problem hiding this comment.
Thanks George! Code wise this LGTM.
@jameskoster sounds good. I will update the component tomorrow 👍
Is there anything left to decided/changed?
Yup we need to display the title in the popover to match the site editor. |
|
Updated the design.
|
|
Some brainstorming based on what I read above. (It might be a sidetrack...:) Template editing mode should be present in one way or another be it in the Site Editor and (somewhat similar much more limited in the) Post Editor. Let's say that a template area does not have any areas included. It would be helpful to keep the same structure in place.
Now let's say that we also need to remove the "Browse all templates" bottom link. Here is the link removed but the bottom black area is still there. Of course it would be better to actually mention why the link is removed instead of just removing the link like I did. |
|
I updated the styling to match the site editor more closely. This affected the changes in #37450 so I brought those over here as well.
|
jameskoster
approved these changes
Dec 20, 2021
carolinan
approved these changes
Dec 20, 2021
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
tellthemachines
pushed a commit
that referenced
this pull request
Dec 21, 2021
* Template Editing Mode: Fix options dropdown * Remove unused TemplateDescription component * Revert "Remove unused TemplateDescription component" This reverts commit e56caee. * Display description for default core templates * Match Site Editor design * Update styling to match site editor Co-authored-by: James Koster <james@jameskoster.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR makes the following changes in the Template Title component:
P.S. We should change the "Delete" text to "Clear customizations" when a template has a theme file. I will address that in separate PR since we're in string freeze, and I want this to be backported in beta 4.
Resolves #37427.
How has this been tested?
Using TT2
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).