Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Block Editor]: Restrict delete multi selected blocks shortcut #37595

Merged
merged 1 commit into from
Dec 23, 2021
Merged

[Block Editor]: Restrict delete multi selected blocks shortcut #37595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/block-editor/src/components/block-tools/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,17 @@ export default function BlockTools( {
} else if (
isMatch( 'core/block-editor/delete-multi-selection', event )
) {
/**
* Check if the target element is a text area, input or
* event.defaultPrevented and return early. In all these
* cases backspace could be handled elsewhere.
*/
if (
[ 'INPUT', 'TEXTAREA' ].includes( event.target.nodeName ) ||
ntsekouras marked this conversation as resolved.
Show resolved Hide resolved
event.defaultPrevented
) {
return;
}
const clientIds = getSelectedBlockClientIds();
if ( clientIds.length > 1 ) {
event.preventDefault();
Expand Down