-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show "group" in multi-select toolbar #37619
Show "group" in multi-select toolbar #37619
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jiteshdhamaniya! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @jiteshdhamaniya, I just happened to stumble on this PR while looking into the possibility of exposing this control. Very cool to see you've already explored this!
It's been a while since you opened the PR, are you keen to continue working on it? Not a worry at all if you currently don't have time to, but if so, it looks like it could use a rebase against trunk
to get it up to date, and I'm happy to help out with testing / reviews.
@@ -114,6 +141,14 @@ export default function BlockToolbar( { hideDragHandle } ) { | |||
{ ( shouldShowVisualToolbar || isMultiToolbar ) && ( | |||
<ToolbarGroup className="block-editor-block-toolbar__block-controls"> | |||
<BlockSwitcher clientIds={ blockClientIds } /> | |||
{ isMultiToolbar && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be worth moving this slightly further down into its own ToolbarGroup
to the right (visually) of the BlockMover
, so that it's in its own section, in case we'd like to add other similar controls in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this should be present in the actual block tools, not in the block type meta functions (transforms, movers, etc).
Thanks again for the work here @jiteshdhamaniya! I've opened up a new PR in #39710 borrowing your changes here, and have made a couple of small changes to deal with some edge cases. |
Description
This PR solves this #34461 issue, add a Group Icon button to Multi Block Toolbar.
How has this been tested?
Screenshots
Types of changes
New feature
Checklist:
*.native.js
files for terms that need renaming or removal).