Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Dashicon readme with more info and a list of icons #37641

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Updated Dashicon readme with more info and a list of icons #37641

wants to merge 2 commits into from

Conversation

evrpress
Copy link
Contributor

I think it would be good to have a list of available icons here so I add them including the names for simple copy-pasting.

@evrpress
Copy link
Contributor Author

Can I add labels on my own? Like [Type] Documentation for this?

@evrpress evrpress changed the title updated Dashicon readme with more info and a list of icons Updated Dashicon readme with more info and a list of icons Dec 28, 2021
@Mamaduka Mamaduka added [Package] Components /packages/components [Type] Developer Documentation Documentation for developers labels Dec 28, 2021
@evrpress evrpress mentioned this pull request Jan 20, 2022
Open
32 tasks
@ciampo ciampo self-requested a review January 20, 2022 11:29
ciampo
ciampo reviewed Jan 20, 2022
View reviewed changes
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @evrpress for this contribution — I left a few inline comments

packages/components/src/dashicon/README.md Show resolved Hide resolved
packages/components/src/dashicon/README.md Show resolved Hide resolved
packages/components/src/dashicon/README.md Outdated Show resolved Hide resolved
@skorasaurus
Copy link
Member

Thanks for this; there haven't edits to the document since this pr ; so this PR is still viable.

@ciampo
Copy link
Contributor

ciampo commented Oct 27, 2022 •
edited
Loading

@evrpress would you be able to rebase this PR and address my earlier feedback?

Let me know when this PR is ready for another review

@evrpress @ciampo
Update packages/components/src/dashicon/README.md
308140f 
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
@evrpress
Copy link
Contributor Author

One of the tests failed. Can you check that @ciampo please?

@ciampo
Copy link
Contributor

ciampo commented Oct 27, 2022

The test failure doesn't seem related, I can restart it

I noticed that you marked a few conversations as solved (1, 2) but I can't actually see the changes that I had suggested applied in this PR — could you double-check and address those comments too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciampo ciampo ciampo left review comments

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@evrpress evrpress

Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evrpress @skorasaurus @ciampo @Mamaduka