Cover: Add layout support #37662
Closed
Cover: Add layout support #37662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Cover
|
Size Change: +79 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
I tried this at some point, for me the main issue was that the "layout" styles didn't apply to the "inner blocks" wrapper but the block wrapper. I don't know how you're dealing with this issue here but for me, we need to change how layout filters/hooks work and try to apply it to the inner blocks wrapper which in some cases (cover) is different than the block wrapper. |
|
Thanks for pointing out the issue, Riad. I've not noticed that, but I'm sure it's still there. I will try to look into possible fixes next week. |
|
@youknowriad, what do you think about introducing the |
|
@Mamaduka I don't think we need any config, I think we should just make the inner blocks parent be the wrapper where the styles are applied. Is that achievable? (Maybe we need some internal hooks to do it) |
|
@youknowriad I need to do more testing, but that might be hard on the server-side: gutenberg/lib/block-supports/layout.php Lines 158 to 165 in a80da69 |
|
A quick note from a UX point of view, I worry about adding this not well understood setting to a commonly used block. For more context on points of confusion: #36082 |
|
Now that layout was added to the column block, it would be great to revisit this PR for 13.1+. Layout control is extremely powerful, mainly because it turns on blockGap for inner blocks, but is admittedly confusing for users. That said, both adding it to more blocks and improving the UI of the layout controls themselves, should ultimately reduce confusion. |
23 tasks
|
Regarding the inner blocks wrapper problem, we could always use the custom solution adopted for the Navigation block in #37473. Ideally there would be a standard way to solve this problem, but if it's non-trivial to work out, the Nav block way will at least ensure we have consistent Layout controls between different types of blocks until we find something better. |
|
Closing in favor of #43504. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds experimental layout support to the Cover block.
Resolves #37036.
Similar to #29982 and #30077.
How has this been tested?
Screenshots
CleanShot.2021-12-30.at.15.44.20.mp4
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).