Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema: Fix appearanceTools in theme.json schema #37762

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

walbo
Copy link
Member

@walbo walbo commented Jan 6, 2022

Description

Fix appearanceTools property in the theme.json schema.

Fixes #37710

How has this been tested?

Create a theme.json file and confirmed appearanceTools is allowed.

{
	"version": 2,
	"settings": {
		"appearanceTools": true,
		"blocks": {
			"core/group": {
				"appearanceTools": true
			}
		}
	}
}

@walbo walbo added the Developer Experience Ideas about improving block and theme developer experience label Jan 6, 2022
@walbo walbo requested review from ajlende and mkaz as code owners January 6, 2022 20:32
Copy link
Contributor

@ajlende ajlende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Mamaduka Mamaduka merged commit 1768e8e into trunk Jan 7, 2022
@Mamaduka Mamaduka deleted the fix/schema-theme-appearance-tools branch January 7, 2022 14:53
@github-actions github-actions bot added this to the Gutenberg 12.4 milestone Jan 7, 2022
@ajlende ajlende added the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Jan 28, 2022
@adamziel adamziel removed the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Experience Ideas about improving block and theme developer experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme JSON Schema marks appearanceTools key as not allowed
4 participants