Show menus selection in placeholder only if available #37980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +42 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
8 tasks
spacedmonkey
approved these changes
Jan 14, 2022
|
Thanks both 🙇 |
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #37884 (comment) @spacedmonkey noticed that the
Select menudropdown will render even if there no menus or no classic menus.This PR improves the conditionals to ensure that the correct pieces only render if they are needed.
How has this been tested?
Select menuoption.Select menudropdown. It should only contain theMenussection and not theClassic Menussection.Appearance -> Menus.Select menuoption. Within the dropdown you should see sections for bothMenusandClassic Menus.Select menudropdown go toManage Menusand delete your Navigation posts.Select menuoption. Within the dropdown you should only see theClassic Menussection and not theMenussection.Now test as a lower permission user:
Select menuoption. Within the dropdown you should only see theMenussection and not theClassic Menussection. This is because the user is allowed to switch to an existing Menu but they are not allowed to create a new menu from a Classic Menu.Screenshots
When there are no Menus or Classic Menus the
Select menuoption is not displayed:Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).