Fix inconsistent response when preloading OPTIONS type requests #38051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-vlasenko
added
[Type] Bug
|
Size Change: +5.75 kB (+1%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
|
See also #28862 |
anton-vlasenko
requested review from
adamziel,
talldan,
tellthemachines,
noisysocks and
getdave
anton-vlasenko
added
the
[Type] Breaking Change
@chrisvanpatten |
|
Just noting that it's related. |
|
Let's note the breaking change in |
getdave
reviewed
Jan 20, 2022
I've completely forgotten that I need to update the changelog. Thank you. |
Thank you for the review, @getdave. |
getdave
reviewed
Jan 24, 2022
There was a problem hiding this comment.
I tested as per the instructions and it worked as expected.
I also searched the codebase for parse: false instances and almost all of them do not use OPTIONS requests. I noted already that canUser does use OPTIONS but that seems ok.
I would appreciate a confidence check from @adamziel or someone else experienced with the data layer.
| } | ||
|
|
||
| return next( options ); | ||
| }; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Add a comment here explaining the purpose of the function. Mainly the "why".
There was a problem hiding this comment.
Thanks.
Fixed in a7b1221
adamziel
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Preloading middleware doesn't return consistent responses for
OPTIONStype requests if theparseoption is set tofalse.This PR aims to fix the preloading middleware so that it returns
window.Responseobject if theparseoption is set to false.Although this is a breaking change I haven't noticed any issues with preloading.
Fixes #37966
How has this been tested?
Expected result (after the fix):
You should see
Responseobject in the console (please see the screenshot), because we chose not to parse the response (parse: false).Actual result (before this fix):
You will see
From middlewaretext in the console as if the response was parsed.Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).