Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare package visibility to query URL handler apps #38377

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Declare package visibility to query URL handler apps #38377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50d7f3b
Declare package visibility to query URL handler apps
hypest Jan 31, 2022
42f5534
Update changelog
hypest Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/react-native-bridge/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,13 @@

## Unreleased

- [***] Fix launching video preview on Android 11+ [#38377]


## 1.70.0

- [**] Fix Android handling of Hebrew and Indonesian translations [#37565]

## 1.70.1

Comment on lines +11 to +13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the PR is already merged I wouldn't apply any correction, but just wanted to share that I think the section shouldn't have been incorporated in this PR as we'll do it when merging the betafix 1.70.1.

Copy link
Contributor Author

@hypest hypest Feb 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, apologies. The version number mentioned for the iOS 13 item is actually 1.50.0 not 1.70.1 😞 .

Let me know if you think we should fix that in a separate PR or you are planning to do it as part of the 1.70.1 process indeed @fluiddot , thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you think we should fix that in a separate PR or you are planning to do it as part of the 1.70.1 process indeed @fluiddot , thanks!

No worries, I'm planning to fix it as part of the release process (reference).

- [***] Bump minimum deployment target to iOS 13.0 [#27577]
11 changes: 11 additions & 0 deletions packages/react-native-bridge/android/react-native-bridge/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,17 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="org.wordpress.mobile.ReactNativeGutenbergBridge">

<queries>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:scheme="http"/>
</intent>
<intent>
<action android:name="android.intent.action.VIEW" />
<data android:scheme="https"/>
</intent>
</queries>

<application>
<activity
android:name=".GutenbergWebViewActivity"
Expand Down