Demo of new preferences package #38435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
force-pushed
the
add/new-preferences-package
branch
from
9d2d3f7
to
02e759a
Compare
|
Size Change: +122 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
talldan
force-pushed
the
add/new-preferences-package
branch
from
017a4e1
to
218fc49
Compare
talldan
commented
Feb 8, 2022
Comment on lines
99
to
107
| export function* toggleFeature( scope, featureName ) { | ||
| deprecated( `dispatch( 'core/interface' ).toggleFeature`, { | ||
| since: '6.0', | ||
| alternative: `dispatch( 'core/preferences' ).toggleFeature`, | ||
| } ); | ||
|
|
||
| yield controls.dispatch( | ||
| preferencesStore.name, | ||
| 'toggleFeature', | ||
| scope, | ||
| featureName | ||
| ); | ||
| } |
There was a problem hiding this comment.
I'm not sure how far to go with deprecations for the interface package.
It is documented as an experimental package.
It doesn't seem possible to access it on the wp global (wp.interface ), but the actions and selectors are all available via wp.data, so I've chosen to deprecate those.
I've deleted the components completely from the package, but open to advice on whether I should also deprecate those.
talldan
added
the
[Type] New API
18 tasks
talldan
force-pushed
the
add/new-preferences-package
branch
2 times, most recently
from
d8bed6f
to
3e6cea3
Compare
talldan
force-pushed
the
add/new-preferences-package
branch
from
f7b7323
to
50bfde1
Compare
talldan
added
[Type] Technical Prototype
8 tasks
|
So great to see your efforts to improve the way preferences are handled in Gutenberg. I appreciate you taking care of it, @talldan. Once your initial roadmap is materialized, we should revisit persisting user preferences on the server. There is some prior art in #19177. I think it's the most frustrating part of the experience to see the welcome guide every time the browser update happens or you open the editor on a different device. |
talldan
force-pushed
the
add/new-preferences-package
branch
5 times, most recently
from
c82a557
to
9e050f6
Compare
talldan
changed the title
talldan
force-pushed
the
add/new-preferences-package
branch
6 times, most recently
from
cfba431
to
4ec19ab
Compare
talldan
force-pushed
the
add/new-preferences-package
branch
from
4ec19ab
to
8ce31d6
Compare
Add initial README Add changelog Add store Update a few things Update edit-widgets to use preferences store Update customize-widgets to use preferences store Update edit-post to use preferences store Update e2e-tests to use preferences store Fixes to preferences Move components to preferences Fix package.json Fix classnames Fix exports Fix stylesheet imports Fix scss issues Fix code examples Update more menu component usage Fix e2e test selector Update package-lock file Re-update package-lock Are we nearly there yet Deprecate old selectors and actions and move tests over Update persisted data migration to migrate from interface Update comment Fix typo Flatten preference store state Fix test Fix tests again Fix persistence Remove useThunks property from preferences store config Simplify preferences store API Update preferences store usage for new api Add autogenerated API docs Update preferences README with new autogenerated API docs Move more menu back to the interface package Rename MoreMenuPreferenceToggle to PreferenceToggleMenuItem Add preference label to spoken message
talldan
force-pushed
the
add/new-preferences-package
branch
from
8ce31d6
to
a1c200a
Compare
|
Closing this as most of the work has now been done in separate PRs. I'm keeping the tracking issue (#31965) up to date with progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses some of #31965
This is a PR that demonstrates migrating what we call 'feature preferences' for each of our editors over to a single package. It should demonstrate everything working in the Post Editor, Widgets Editor and Customize Widgets Editor (the site editor will follow later). As this is quite a sizeable PR for review, I'll split this into separate pull requests in the following order:
@wordpress/preferencespackage #38873After that:
Background
Previously each editor implemented its own preferences in the editor store, but this made it hard to share infrastructure between editors and didn't provide a foundation for cross-editor settings (#24370).
At the end of last year I move ahead with refactoring these preferences into the
interfacepackage, but then after further discussion a separatepreferencespackage was proposed.