Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog: Add missed entries for recent typing fixes and tweaks #38469

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Changelog: Add missed entries for recent typing fixes and tweaks #38469

merged 2 commits into from
Feb 3, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw commented Feb 3, 2022 •
edited by andrewserong
Loading

Related:

Description

Recent tweaks to the components packages typing of components missed including entries to the changelog. This PR adds them.

Testing Instructions

  1. Proofread changelog entries.

Types of changes

Documentation.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@aaronrobertshaw aaronrobertshaw self-assigned this Feb 3, 2022
andrewserong
andrewserong approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding in these changelog entries. The descriptions read well, and confirmed that all the links point to the right places 👍

@andrewserong andrewserong added [Feature] UI Components Impacts or related to the UI component system [Type] Developer Documentation Documentation for developers labels Feb 3, 2022
This was referenced Feb 3, 2022
Merged
Merged
Merged
Merged
@aaronrobertshaw aaronrobertshaw merged commit 9e8e81c into trunk Feb 3, 2022
@aaronrobertshaw aaronrobertshaw deleted the update/components-changelog-after-typing-fixes branch February 3, 2022 05:23
@github-actions github-actions bot added this to the Gutenberg 12.6 milestone Feb 3, 2022
@ciampo ciampo added the [Package] Components /packages/components label Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewserong andrewserong andrewserong approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@aaronrobertshaw aaronrobertshaw

Labels
[Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 12.6
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronrobertshaw @andrewserong @ciampo