Blocks: Use cite instead of footer for the pullquote block's markup #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
3 tasks
mcsf
added a commit
that referenced
this pull request
Dec 14, 2017
Fixes a visual regression introduced in #3851
3 tasks
mcsf
reviewed
Dec 14, 2017
| @@ -2,7 +2,7 @@ | |||
| margin: 0 0 16px; | |||
| box-shadow: inset 0px 0px 0px 0px $light-gray-500; | |||
|
|
|||
| footer { | |||
| cite { | |||
There was a problem hiding this comment.
This change caused a visual regression in the editor, since the citation Editable's tagName wasn't updated to cite. Possible fix: #4013
There was a problem hiding this comment.
The CSS selector should have been:
cite,
footer {}... in any case, to not break compat.
There was a problem hiding this comment.
@jasmussen @karmatosed does this make sense to you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs updates the pullquote block to use
citeinstead offooter(same as quote).There were also some leftover style changes required for the quote block.