-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile Release v1.70.3 #38680
Mobile Release v1.70.3 #38680
Conversation
…a gallery item (#38238) * Add the native variant of MediaReplaceFlow Since the MediaReplaceFlow component is not implemented yet in the native version of the editor, we return an empty component instead. * Set MediaPlaceholder props by platform in gallery * Update react-native-editor changelog * Remove autoOpenMediaUpload from web props `autoOpenMediaUpload` prop is only used in the native version of the `MediaPlaceholder` component hence, we don't need to define it in the props set for the web version. * Add gallery block integration tests * Unify shared props between web and native
* Declare package visibility to query URL handler apps * Update changelog
…during filtering (#38670) * Check if style value is defined before removing extra spaces * Add test case for old text color format * Update react-native-editor changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved via wordpress-mobile/gutenberg-mobile#4565 (review)
# Conflicts: # packages/block-library/src/gallery/test/index.native.js # packages/react-native-aztec/package.json # packages/react-native-bridge/package.json # packages/react-native-editor/CHANGELOG.md # packages/react-native-editor/ios/Podfile.lock # packages/react-native-editor/package.json
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "arm64 "; | ||
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these changes were introduced in 1.70.3
but I don't recall any modification in the fix (reference) related to this. @mchowning I'm wondering if you have any clue about where this change came from, thanks 🙇 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't. 🤔
It looks like @geriux made the opposite change for the 1.70.2 release. Perhaps he has some insight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good catch, I didn't recall the change 😅. If the change was introduced in 323791a for the 1.70.2
release, I'm wondering why it's not in trunk
🤔. In any case, I think the change is valid as it's not expected that we exclude the arm64
architecture for the simulator hence, I'll go ahead and merge the PR once the CI checks pass.
Description
Release 1.70.3 of the react-native-editor and Gutenberg-Mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#4565
Checklist:
*.native.js
files for terms that need renaming or removal).