Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Release v1.70.3 #38680

Merged
merged 19 commits into from
Feb 10, 2022
Merged

Mobile Release v1.70.3 #38680

merged 19 commits into from
Feb 10, 2022

Conversation

mchowning
Copy link
Contributor

Description

Release 1.70.3 of the react-native-editor and Gutenberg-Mobile.

For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#4565

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

fluiddot and others added 17 commits January 20, 2022 11:12
…a gallery item (#38238)

* Add the native variant of MediaReplaceFlow

Since the MediaReplaceFlow component is not implemented yet in the native version of the editor, we return an empty component instead.

* Set MediaPlaceholder props by platform in gallery

* Update react-native-editor changelog

* Remove autoOpenMediaUpload from web props

`autoOpenMediaUpload` prop is only used in the native version of the `MediaPlaceholder` component hence, we don't need to define it in the props set for the web version.

* Add gallery block integration tests

* Unify shared props between web and native
* Declare package visibility to query URL handler apps

* Update changelog
@mchowning mchowning added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Feb 9, 2022
…during filtering (#38670)

* Check if style value is defined before removing extra spaces

* Add test case for old text color format

* Update react-native-editor changelog
@fluiddot fluiddot marked this pull request as ready for review February 10, 2022 15:52
@fluiddot fluiddot requested a review from SiobhyB February 10, 2022 15:54
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Conflicts:
#	packages/block-library/src/gallery/test/index.native.js
#	packages/react-native-aztec/package.json
#	packages/react-native-bridge/package.json
#	packages/react-native-editor/CHANGELOG.md
#	packages/react-native-editor/ios/Podfile.lock
#	packages/react-native-editor/package.json
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "arm64 ";
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these changes were introduced in 1.70.3 but I don't recall any modification in the fix (reference) related to this. @mchowning I'm wondering if you have any clue about where this change came from, thanks 🙇 .

Copy link
Contributor Author

@mchowning mchowning Feb 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't. 🤔

It looks like @geriux made the opposite change for the 1.70.2 release. Perhaps he has some insight.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before that, it actually looks like @fluiddot 😄 was the last person to add to add the "arm64" exclusion: a910139

Copy link
Contributor

@fluiddot fluiddot Feb 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch, I didn't recall the change 😅. If the change was introduced in 323791a for the 1.70.2 release, I'm wondering why it's not in trunk 🤔. In any case, I think the change is valid as it's not expected that we exclude the arm64 architecture for the simulator hence, I'll go ahead and merge the PR once the CI checks pass.

@fluiddot fluiddot merged commit b54c2d8 into trunk Feb 10, 2022
@fluiddot fluiddot deleted the rnmobile/release_1.70.3 branch February 10, 2022 20:02
@github-actions github-actions bot added this to the Gutenberg 12.7 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants