BaseControl: Refactor stories to use Controls #38741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Package] Components
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
ciampo
approved these changes
Feb 11, 2022
| parameters: { | ||
| knobs: { disable: false }, | ||
| }, | ||
| subcomponents: { BaseControl: BaseControl.VisualLabel }, |
There was a problem hiding this comment.
TIL about the subcomponents flag — it's probably something that we should use in all stories related to a component "family" — e.g. Card, ItemGroup, ToolsPanel...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35665
In preparation for #38730
Description
Refactors stories for
BaseControlto use Controls instead of Knobs.Also adds a story for
BaseControl.VisualLabel, with some inline notes to prevent misuse.Testing Instructions
npm run storybook:devBaseControland compare with https://wordpress.github.io/gutenberg/?path=/story/components-basecontrol--defaultTypes of changes
Storybook only.
Checklist:
*.native.jsfiles for terms that need renaming or removal).