Plugin: Remove the experimental Progressive Web Apps (PWA) integration #38810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
TimothyBJacobs and
spacedmonkey
as code owners
|
Size Change: -1.24 kB (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
This was referenced Feb 16, 2022
|
@ellatrix: anything blocking the merge here? |
|
I triggered e2e tests again, but the test failures didn't look related to this PR. |
gziolo
approved these changes
Feb 22, 2022
|
Just getting the tests to pass. Already rebased it, but some other (flaky?) tests now fail. |
|
Should we try another rebase in case the test was fixed in the meantime? |
|
@ellatrix, can you rebase this one and merge? |
gziolo
added
Gutenberg Plugin
gziolo
changed the title
|
@ellatrix @gziolo I'm not sure how the autocomplete tests could possibly related to the PWA integration, but they've been failing since this was merged. They were also failing in the last commit on this branch. Seems like a bug might have been introduced here? It'd be appreciated if you could add a comment about why you'd merge a PR with failing CI, because it leaves those of us in a different timezone very confused and blocked. |
|
There's a JS error buried in the test failure that might provide some clues: Expected mock function not to be called but it was called with:
["jQuery.Deferred exception: Cannot read properties of undefined (reading 'data') TypeError: Cannot read properties of undefined (reading 'data')
at f (../../http:/localhost:8889/wp-admin/js/user-profile.min.js?ver=6.0-alpha-52822:2:195)
at v (../../http:/localhost:8889/wp-admin/js/user-profile.min.js?ver=6.0-alpha-52822:2:1207)
at HTMLDocument.<anonymous> (../../http:/localhost:8889/wp-admin/js/user-profile.min.js?ver=6.0-alpha-52822:2:5150)
at e (../../http:/localhost:8889/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,utils,zxcvbn-async&ver=6.0-alpha-52822:2:30038)
at t (../../http:/localhost:8889/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,utils,zxcvbn-async&ver=6.0-alpha-52822:2:30340) "]
at runMicrotasks (<anonymous>)That's possibly happening when the test creates a user. I couldn't reproduce it locally though. |
This PR only removes code added #33102. I didn't anticipate it would break anything since no tests were updated in the original PR. Anyway, we can revert it and add back the removed code. It's a very strange issue and should never break any tests. |
Yeah, I don't get it either. Thanks for putting up a PR for reverting the revert. Lets see what happens with the tests on that one. |
Tests pass in the PR. Let's land that one and I will open another PR that attempts to revert this functionality. I'm really curious what type of bug we have in Gutenberg. I hope it's related only to the test setup. |
|
Reverted with #33102. I will open another PR and try to fix the issue with tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts #33102. I thought this was a cool experiment at the time with the idea to expand the service worker with offline editing capabilities, but this is not a priority at the moment and it's not worth the time to currently maintain without the extra capabilities.
Testing Instructions
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).