Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for late static binding in the resolver #38857

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Feb 16, 2022

A follow-up to #38625 and #38671

This makes sure that late static binding work properly, letting child classes to override the protected methods and they'll be called instead of the parent's.

Props to @Mamaduka for bringing this up as something missing while doing the backport at WordPress/wordpress-develop#2322

@oandregal oandregal self-assigned this Feb 16, 2022
@oandregal oandregal added Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Feb 16, 2022
@oandregal oandregal requested a review from Mamaduka February 16, 2022 12:16
@oandregal
Copy link
Member Author

This is being backported by @Mamaduka as part of WordPress/wordpress-develop#2322

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@oandregal oandregal merged commit d29eec8 into trunk Feb 16, 2022
@oandregal oandregal deleted the update/resolver-late-static-bindings branch February 16, 2022 15:31
@github-actions github-actions bot added this to the Gutenberg 12.7 milestone Feb 16, 2022
@Mamaduka Mamaduka removed the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants