-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix npm run docs:build
crashing when a block.json
lacks supports
key.
#39241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Type] Bug
An existing feature does not function as intended
[Type] Build Tooling
Issues or PRs related to build tooling
labels
Mar 6, 2022
ZebulanStanphill
requested review from
ntwb,
nerrad,
ajitbohra and
oandregal
as code owners
March 6, 2022 20:44
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Mar 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Type] Bug
An existing feature does not function as intended
[Type] Build Tooling
Issues or PRs related to build tooling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on a new PR to finish the
<details>
block, I discovered a bug when runningnpm run docs:build
:Turns out that a
block.json
without asupports
key causes the doc-gen command to throw. Theblock.json
schema does not require that key, so I decided to whip up a quick PR to fix the issue. I've confirmed that the fix in this PR works by rebasing my WIP<details>
block branch on this PR's branch and verifying thatnpm run docs:build
works as intended.Testing Instructions
supports
key from a core block'sblock.json
.npm run docs:build
and ensure that no errors are thrown.Checklist:
*.native.js
files for terms that need renaming or removal).