-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NumberControl
validation
#39260
Draft
stokesman
wants to merge
6
commits into
trunk
Choose a base branch
from
fix/number-control-validation-2
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix NumberControl
validation
#39260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use the blur event to commit invalid values allowing extending components like `NumberControl` to resolve the value on commmit.
7 tasks
Size Change: +166 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping this drafted as it would be important to first correct the stepping behavior of
NumberControl
so that it does not step to invalid values #34566.What
This PR enables consumers of
NumberControl
to expect that values received by itsonChange
handler will be valid according to itsmin
,max
,step
andrequired
props.It adds unit tests to cover the new behavior.
It also includes a small change to
RangeControl
needed to maintain its current behavior on top of the changed behavior ofNumberControl
.Why
To fix #33291
How
Primarily (on a high-level) by changes to
NumberControl
so that itonChange
with invalid valuesMuch of the changes required to support that were in
InputControl
since the behavior ofNumberControl
is rooted there. The changes toInputControl
make it so that itonChange
with invalid values (like it already does for dirty values)commit
onblur
(like it already does for dirty values)onValidate
before changes (whenisPressEnterToChange
isfalse
)invalidate
actionsTesting Instructions
will update…
Screenshots
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).