Core Data: Add types to createBatch
#39475
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -9 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
adamziel
force-pushed
the
types/core-data-create-batch
branch
from
7fe17d8
to
5297db7
Compare
|
Batch API is experimental, so it might be a good opportunity to see if |
dmsnell
force-pushed
the
types/core-data-create-batch
branch
from
5297db7
to
55ee54e
Compare
|
The static analysis error doesn't seem to make sense: That type is there and my IDE even autocompletes it. Any ideas what went wrong here? |
Types the `createBatch` and default batch processor in preparation for more extensive typing work in `core/data`.
adamziel
force-pushed
the
types/core-data-create-batch
branch
from
55ee54e
to
f4da9cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #28210 which introduced this revision of the batch system.
Part of #39211 and the work of prepping
core/datafor useful types.Types the
createBatchand default batch processor inpreparation for more extensive typing work in
core/data.Testing
Apart from a few renames there should only be a single code change in this
patch: a fix in
ObservableSetthat wasn't exploited.Setwhich doesn't allow that.Set.ObservableSetisn't exported and was only ever constructed with no constructor args.Please audit the types and make sure that some actions which utilize the batch system complete as expected.
Type of changes
These are almost entirely type-level changes apart from the noted fix.