Global styles: remove block gap control #39601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. It's not supported at the root level in ROOT_BLOCK_SUPPORTS 2. It doesn't work at the individual block level in global styles
ramonjd
added
[Type] Enhancement
|
Size Change: -94 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
This tests as advertised for me. 👍
✅ Confirmed on trunk that blockGap isn't displayed at the root global styles level
✅ Confirmed on trunk that blockGap global styles for individual blocks didn't work e.g. Social Icons
✅ Didn't find any reference to gap on published page
✅ After checking out this branch blockGap controls did not show at root or individual block levels
The changes LGTM. I may be missing a little context on the reasoning behind this PR so might pay to wait for @andrewserong's approval.
andrewserong
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
This is testing well for me, too, thanks for putting it together so quickly @ramonjd! 🤞 we'll be able to re-introduce the feature before too long 😀
| Block spacing is no longer available in global styles | Block spacing is still available within the post and site editors, just at the individual block level |
|---|---|
 |
 |
LGTM! 🚀
jostnes
pushed a commit
to jostnes/gutenberg
that referenced
this pull request
Mar 23, 2022
1. It's not supported at the root level in ROOT_BLOCK_SUPPORTS 2. It doesn't work at the individual block level in global styles
|
Hey folks, while removing this from the "blocks" global styles is a good call here, I'm a bit confused about why we need to remove it from the global level. I see that you mention that it didn't work, can we fix that instead? I know that when I removed the CSS variables from the blocks block gap behavior, I intentionally kept the variable as a fallback in the generated styles to be able to support defining the block gap at the root level. |
|
@ramonjd @andrewserong @aaronrobertshaw this was a very intentional and important feature of global styles to help design visual rhythm :D
|
|
Thanks for the heads up @youknowriad and @mtias Revert commit here: #39845 Was a bit of a shotgun approach admittedly. I'll look more closely at what is not working and create issues/fix it. Related: |
|
Thanks! |
Thanks for following up, @ramonjd! Yes, just confirming that the intention is definitely to fix it and have it working properly in time for WP 6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove the block gap controls from Global Styles sidebar. Props to @andrewserong for noticing.
Why?
How?
BANISHED!
Testing Instructions
Before checking out this branch, ensure that blockGap doesn't:
Publish a page after you've set a few Global Style block gap values. Check the source of the published page for any trace of your
gapvalue. Any?git checkout -t origin/remove/global-styles-block-gap-controlScreenshots or screencast
Before
After