Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some extra social icons #39609

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

aezazs-multidots
Copy link

What?

We have added Bitbucket, Slack, Messenger, and Whatsapp social icons to the social icons block.

Why?

Because there are many social icons, they are not included in the social icons blocks. And those social icons are getting used a lot in the WordPress website. so I have added some social icons.

Testing Instructions

Select Block Social Icons on any page or post.
Now you can select and use the icons which we have added.

Screenshots or screencast

I have added social icons, its video link is given below.
https://www.loom.com/share/d232bbf6c1ad4ea5b8a456c375c6f217

social-icons

@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @aezazs-multidots! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 21, 2022
@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Social Affects the Social Block - used to display Social Media accounts labels Mar 21, 2022
@mtias mtias added the Needs Design Feedback Needs general design feedback. label Mar 28, 2022
@jasmussen
Copy link
Contributor

Thanks for the PR. As a completely personal opinion, I'm reluctant to add more icons:

  • Logos change, and it's a maintenance burden to keep up with the designs, and frustrating having to wait for an icon to be updated if it becomes out of date
  • Often logos have design guidelines attached to their usage, for example disallowing their use without the accurate brand color, rules which are hard or impossible for the block to uphold.
  • We can't add all icons in the world, making it all the harder to decide between which icons we do add, and which icons we choose not to.

In that light, my hope lies with #19041, creating a basic extension architecture making it trivial for anyone to add the icons of their choice.

@audunmb
Copy link

audunmb commented Jun 19, 2023

The Social icons block is just a row of icons. Just replace the whole thing with something based on The Icon Block and place SVG Icons in a row.

No need to maintain a lot of icons or links, leave that to admins and theme developers, and people can add and modify whatever icons they want.

A standard pattern with a row of the most used social icons could replace the current block for backwards compatability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants