-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added some extra social icons #39609
base: trunk
Are you sure you want to change the base?
added some extra social icons #39609
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @aezazs-multidots! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Thanks for the PR. As a completely personal opinion, I'm reluctant to add more icons:
In that light, my hope lies with #19041, creating a basic extension architecture making it trivial for anyone to add the icons of their choice. |
The Social icons block is just a row of icons. Just replace the whole thing with something based on The Icon Block and place SVG Icons in a row. No need to maintain a lot of icons or links, leave that to admins and theme developers, and people can add and modify whatever icons they want. A standard pattern with a row of the most used social icons could replace the current block for backwards compatability. |
What?
We have added Bitbucket, Slack, Messenger, and Whatsapp social icons to the social icons block.
Why?
Because there are many social icons, they are not included in the social icons blocks. And those social icons are getting used a lot in the WordPress website. so I have added some social icons.
Testing Instructions
Select Block Social Icons on any page or post.
Now you can select and use the icons which we have added.
Screenshots or screencast
I have added social icons, its video link is given below.
https://www.loom.com/share/d232bbf6c1ad4ea5b8a456c375c6f217