-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Remove error banners from native media&text and audio blocks #39694
Conversation
Size Change: +299 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
1523efb
to
c8de7a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested on both iOS and Android emulators. In my testing, I can confirm everything looked good after uploading via a device while offline on both platforms, the redundant message is gone and the main message remains. Yay for less clutter 🎉
I also tested other flows for adding audio, including "add from URL", and couldn't find any unintentional regressions.
As this is a user-facing change, perhaps it should be noted in the changelog too?
Going ahead to approve this PR, thanks Matt! 🙌
Thanks for the review @SiobhyB ! 🙇
Good point. I made that update. |
What?
Fixes wordpress-mobile/gutenberg-mobile#4247 by removing the error banner that appeared at the top of the screen when an upload failed on native in the Media&Text or Audio blocks.
Why?
The error information is already contained within the block itself and WPAndroid also sends a second error banner already.
How?
Removing the calls to
createErrorNotice
.Testing Instructions
Perform the following with both the (1) Audio and (2) Media&Text blocks:
Note that WPiOS does not display the bottom banner shown in the screenshots.