Theme JSON compat: refer to static instead of self for ROOT_BLOCK_SELECTOR const #39921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
requested review from
talldan,
glendaviesnz,
tellthemachines and
aaronrobertshaw
ramonjd
changed the title
aaronrobertshaw
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
LGTM 👍
✅ Works as advertised.
I believe it was actually @tellthemachines that spotted this one. 🕵️♀️
Props to @tellthemachines 💟 |
…ECTOR` made it in. It should be static to retain the inheritance powers introduced in #38671
ramonjd
force-pushed
the
update/theme-json-compat-static-const
branch
from
bce8060
to
89a76f3
Compare
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
self::ROOT_BLOCK_SELECTORshould bestatic::ROOT_BLOCK_SELECTORWhy?
While porting the get_block_classes in #38816 a
self::ROOT_BLOCK_SELECTORmade it in. It should be static to retain the inheritance powers introduced in #38671How?
Renamed
self::tostatic::Testing Instructions
Add new post with some Group blocks.
Publish said post.
Check out the frontend:
<style id='global-styles-inline-css'>in the source.Props to @aaronrobertshaw for spotting