-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate style variation test to Playwright #40216
Conversation
Size Change: +1.77 kB (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left some nitpicks, overall looks good.
We should delete the original test file though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Co-authored-by: Kai Hao <kevin830726@gmail.com>
await pageUtils.createNewPost(); | ||
|
||
// Inserting a quote block | ||
await pageUtils.insertBlock( { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, as far as I understand, this PR changed the original test behaviour. Previously, we:
- added a block
- typed some content
These steps covered the case for which we wanted to make sure that users could type right after the block was inserted.
The playwright test does this instead:
- adds a block with the contents we want
It doesn't look like we're testing for typing. Sorry, I'm not very familiar with playwright, but shouldn't we respect the existing behavior when migrating tests? @JustinyAhin @kevin940726
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What?
Migrate
style-variation.test.js
to its Playwright version.Why?
See #38570 for its background and rationale.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run
npm run test-e2e:playwright -- /test/e2e/specs/editor/various/style-variation.spec.js
.