-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multi-selection]: Copy whole block when selection is collapsed #40374
Merged
ntsekouras
merged 2 commits into
trunk
from
fix/copy-whole-block-when-selection-is-collapsed
Apr 15, 2022
Merged
[Multi-selection]: Copy whole block when selection is collapsed #40374
ntsekouras
merged 2 commits into
trunk
from
fix/copy-whole-block-when-selection-is-collapsed
Apr 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
An existing feature does not function as intended
[Feature] Block Multi Selection
The ability to select and manipulate multiple blocks
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
labels
Apr 15, 2022
Size Change: +55 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
mcsf
approved these changes
Apr 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
adamziel
pushed a commit
that referenced
this pull request
Apr 19, 2022
* [Multi-selection]: Copy whole block when selection is collapsed * rename var to shouldHandleWholeBlocks
adamziel
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Apr 19, 2022
This was cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Block Multi Selection
The ability to select and manipulate multiple blocks
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Based on @mcsf ' s #40098 (comment)
Currently if we had a collapsed selection we would expand the selection to the whole block and that required pressing
cmd +v/c
twice to copy the whole block. This PR checks about a collapsed selection and properly copies/cuts the whole block in that caseHow?
I added a new
__unstableIsSelectionCollapsed
selector and not integrated the checks with__unstableIsFullySelected
to better separate the concerns.Testing Instructions