Fix incorrect results in the flaky tests reporter #40567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Bug
kevin940726
force-pushed
the
fix/flaky-test-reporter
branch
from
f1f7980 to
bcd43c7
Compare
|
Size Change: -132 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
kevin940726
commented
Apr 25, 2022
.github/report-flaky-tests/index.js
Outdated
| `(?<=${ TEST_RESULT.close })\n(?:\.\.\.\n)?(?=${ TEST_RESULT.open })` | ||
| ) | ||
| ); | ||
| let testResultsList = body.includes( TEST_RESULTS_LIST.open ) |
There was a problem hiding this comment.
Due to the previous error, some issues have been updated to an incorrect state without the open tag of the results list. We check here and discard the incorrect errors to start a new one.
georgeh
added
the
[Type] Automated Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix incorrect results in the flaky tests reporter introduced in #38570.
Why?
It's causing the flaky test reports to have wrong formatted error messages.
How?
By fixing a duplicate function name (
renderTestResults), which is valid in JavaScript and I totally missed it... 😓Testing Instructions
Unfortunately, it can't be easily tested.