Global Styles Sidebar: Fix nav header styles and semantics #40592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
Global Styles
This was referenced Apr 25, 2022
|
Size Change: +4 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Apr 25, 2022
| <NavigatorBackButton | ||
| style={ | ||
| // TODO: This style override is also used in ToolsPanelHeader. | ||
| // It should be supported out-of-the-box by Button. |
There was a problem hiding this comment.
Good point — it looks like there are already some styles that go in that direction, but they don't seem as comprehensive as they should be
Apart from ToolsPanelHeader, I also found overrides in BorderControl.
Definitely something to follow-up with
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38934
Based on #40590
What?
Fixes visual and semantic issues with the navigation header in the Global Styles sidebar.
Why?
listitemsemantics even though this isn't functionally a list. (Addressed in Global Styles Sidebar: RenameNavigationButtonso semantics are clearer #40590)How?
NavigatorBackButton.✅ Design review was done in #40533
Testing Instructions
npm run devScreenshots or screencast
More after shots