-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Automated Testing]: Fix partial selection copy flaky tests #40607
Conversation
Thanks! I noticed that some tests below also have the similar code, do we want to also add them there? |
Size Change: +13 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
I don't think is needed right now, as they always succeed and are |
I actually tried that without the custom
Hence, I think we probably still need them and they only succeed only by chance (or some other reasons 😅).
I forgot the details but IIRC it has something to do with the native clipboard event/keybinding doesn't work in headless mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a million! Let's merge it after CI passes 👍
What?
Fixes: #40307
Fixes: #40303
Fixes partial selection flaky tests caused by intermittent proper placement of the caret.