[Block Library - Query Loop]: Add parents filter
#40933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
ntsekouras
requested review from
mcsf,
Mamaduka,
youknowriad,
aristath,
paaljoachim and
carolinan
|
Size Change: +632 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
May 11, 2022
packages/block-library/src/query/edit/inspector-controls/parent-control.js
Outdated
Show resolved
Hide resolved
Mamaduka
reviewed
May 11, 2022
packages/block-library/src/query/edit/inspector-controls/parent-control.js
Outdated
Show resolved
Hide resolved
Mamaduka
reviewed
May 11, 2022
packages/block-library/src/query/edit/inspector-controls/parent-control.js
Outdated
Show resolved
Hide resolved
ntsekouras
force-pushed
the
add/parent-filter-in-query-loop
branch
from
dde8d1d to
30e5bb4
Compare
Mamaduka
reviewed
May 13, 2022
packages/block-library/src/query/edit/inspector-controls/parent-control.js
Show resolved
Hide resolved
ntsekouras
force-pushed
the
add/parent-filter-in-query-loop
branch
from
0063668 to
76417f9
Compare
This was referenced Sep 9, 2022
bph
added
the
Needs Dev Note
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Sep 15, 2022
…enberg repository. This changeset backports changes from the following Gutenberg pull requests: - [WordPress/gutenberg#43590 gutenberg#43590] Add a filter to `build_query_vars_from_query_block` - [WordPress/gutenberg#40933 gutenberg#40933] Block Library - Query Loop: Add parents filter Props ntsekouras, bernhard-reiter. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54175 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Sep 15, 2022
…enberg repository. This changeset backports changes from the following Gutenberg pull requests: - [WordPress/gutenberg#43590 gutenberg#43590] Add a filter to `build_query_vars_from_query_block` - [WordPress/gutenberg#40933 gutenberg#40933] Block Library - Query Loop: Add parents filter Props ntsekouras, bernhard-reiter. See #56467. Built from https://develop.svn.wordpress.org/trunk@54175 git-svn-id: http://core.svn.wordpress.org/trunk@53734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Sep 15, 2022
…enberg repository. This changeset backports changes from the following Gutenberg pull requests: - [WordPress/gutenberg#43590 gutenberg#43590] Add a filter to `build_query_vars_from_query_block` - [WordPress/gutenberg#40933 gutenberg#40933] Block Library - Query Loop: Add parents filter Props ntsekouras, bernhard-reiter. See #56467. Built from https://develop.svn.wordpress.org/trunk@54175 git-svn-id: https://core.svn.wordpress.org/trunk@53734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
whereiscodedude
pushed a commit
to whereiscodedude/wpss
that referenced
this pull request
Sep 18, 2022
…enberg repository. This changeset backports changes from the following Gutenberg pull requests: - [WordPress/gutenberg#43590 gutenberg#43590] Add a filter to `build_query_vars_from_query_block` - [WordPress/gutenberg#40933 gutenberg#40933] Block Library - Query Loop: Add parents filter Props ntsekouras, bernhard-reiter. See #56467. Built from https://develop.svn.wordpress.org/trunk@54175
20 tasks
38 tasks
ootwch
pushed a commit
to ootwch/wordpress-develop
that referenced
this pull request
Nov 4, 2022
…enberg repository. This changeset backports changes from the following Gutenberg pull requests: - [WordPress/gutenberg#43590 gutenberg#43590] Add a filter to `build_query_vars_from_query_block` - [WordPress/gutenberg#40933 gutenberg#40933] Block Library - Query Loop: Add parents filter Props ntsekouras, bernhard-reiter. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54175 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #34033
Part of: #24934
This PR adds
parentfiltering support in Query Loop with a new property in existingqueryattribute, calledparents. The filter is only shown forhierarchicalpost types and if you have selected multiple parents it will display the children of all of them(union).How?
Testing Instructions
hierarchicalpost type, likePage.Parentscontrol and start typing there to see suggestions.Query Loopblocks.Screenshots or screencast
Screen.Recording.2022-05-09.at.2.46.20.PM.mov