Editor preferences: update order and copy #40981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- making the copy the same - placing common preferences in the same order
ramonjd
added
[Type] Enhancement
|
Size Change: +18 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ramonjd
force-pushed
the
update/editor-preferences-order
branch
from
e539dfd to
c2bc5fc
Compare
There was a problem hiding this comment.
Thanks for following up @ramonjd! That's looking nicer to me having the consistency between the two sets of preferences. Just left a tiny nit about adding a full-stop, but otherwise LGTM!
andrewserong
approved these changes
May 11, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update preferences pane to:
See:
#40757 (review)
props to @andrewserong
Before
After
Why?
To unify the panels, make things more predictable, reduce cognitive load for users.
How?
Rejigging the order of the EnableFeature components.
Testing Instructions
Fire up this branch, then check that the site and post editor preference options make sense to you.