Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site Editor]: Update single default template copy #41302

Merged
merged 2 commits into from
May 25, 2022

Conversation

ntsekouras
Copy link
Contributor

@ntsekouras ntsekouras commented May 25, 2022

What?

Part of: #37407
Needed for: #41189

In order to add more template types we need to update some copy from the current default templates provided.

This PR intents to update the single template copy as it's needed to clear up ambiguity between the single template that is the fallback for any custom post type(including post) and the menu item to be added in the linked PR, that will allow the creation the single-post template and any single_$post_type template.

Testing Instructions

  1. In site editor go to templates list
  2. Click the Add new button to create a new template
  3. Observe that the previous Single Post menu item has new copy

Important Everything else should work as expected without any regression. This includes the existing themes/templates, creation flow, resolution of templates, etc..

@ntsekouras ntsekouras added [Feature] Full Site Editing [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels May 25, 2022
@ntsekouras ntsekouras self-assigned this May 25, 2022
),
'single' => array(
'title' => _x( 'Single', 'Template name', 'gutenberg' ),
'description' => __( 'Displays any single post type.', 'gutenberg' ),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the actual changes for single template.

@ntsekouras ntsekouras requested a review from ockham May 25, 2022 08:52
@jameskoster
Copy link
Contributor

The description is tricky. It would be good to indicate the relationship between this template and the more specific alternatives.

For reference here's what we have currently in #41189 for single-$posttype:

Screenshot 2022-05-25 at 09 56 20

Perhaps something like:

The default template for displaying any single post or attachment

What do you think?

@ntsekouras ntsekouras force-pushed the update/single-default-template-copy branch from 55d1b4b to a9a59b9 Compare May 25, 2022 09:42
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks, Nik.

I will leave the final copy review to @jameskoster 🙇

Screenshot

CleanShot 2022-05-25 at 13 51 12

lib/compat/wordpress-6.1/block-template-utils.php Outdated Show resolved Hide resolved
Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
@jameskoster
Copy link
Contributor

It makes sense to me but it might be good to get input from themers :)

Copy link
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ntsekouras ntsekouras merged commit 9c1c67b into trunk May 25, 2022
@ntsekouras ntsekouras deleted the update/single-default-template-copy branch May 25, 2022 12:17
@github-actions github-actions bot added this to the Gutenberg 13.4 milestone May 25, 2022
youknowriad pushed a commit that referenced this pull request May 26, 2022
* [Site Editor]: Update single default template copy

* Update lib/compat/wordpress-6.1/block-template-utils.php

Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>

Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 2, 2022
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Sep 8, 2022
In order to add more template types we need to update some copy from the current default templates provided.

This updates the `single` template copy as it's needed to clear up the ambiguity between the single template that is the fallback for any custom post type (including `post`) and the menu item to be added in a subsequent commit, that will allow the creation the `single-post` template and any `single_$post_type` template.

This commit backports the original PR from Gutenberg repository:
* [WordPress/gutenberg#41302 #41302: Site Editor: Update single default template copy]

Follow-up to [52062], [52331].

Props ntsekouras, bernhard-reiter, jameskoster, Mamaduka, scruffian.
Fixes #56534.
Built from https://develop.svn.wordpress.org/trunk@54104


git-svn-id: http://core.svn.wordpress.org/trunk@53663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to platformsh/wordpress-performance that referenced this pull request Sep 8, 2022
In order to add more template types we need to update some copy from the current default templates provided.

This updates the `single` template copy as it's needed to clear up the ambiguity between the single template that is the fallback for any custom post type (including `post`) and the menu item to be added in a subsequent commit, that will allow the creation the `single-post` template and any `single_$post_type` template.

This commit backports the original PR from Gutenberg repository:
* [WordPress/gutenberg#41302 #41302: Site Editor: Update single default template copy]

Follow-up to [52062], [52331].

Props ntsekouras, bernhard-reiter, jameskoster, Mamaduka, scruffian.
Fixes #56534.
Built from https://develop.svn.wordpress.org/trunk@54104


git-svn-id: https://core.svn.wordpress.org/trunk@53663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pbearne pushed a commit to pbearne/wordpress-develop that referenced this pull request Sep 9, 2022
In order to add more template types we need to update some copy from the current default templates provided.

This updates the `single` template copy as it's needed to clear up the ambiguity between the single template that is the fallback for any custom post type (including `post`) and the menu item to be added in a subsequent commit, that will allow the creation the `single-post` template and any `single_$post_type` template.

This commit backports the original PR from Gutenberg repository:
* [WordPress/gutenberg#41302 #41302: Site Editor: Update single default template copy]

Follow-up to [52062], [52331].

Props ntsekouras, bernhard-reiter, jameskoster, Mamaduka, scruffian.
Fixes #56534.

git-svn-id: https://develop.svn.wordpress.org/trunk@54104 602fd350-edb4-49c9-b593-d223f7449a82
whereiscodedude pushed a commit to whereiscodedude/wpss that referenced this pull request Sep 18, 2022
In order to add more template types we need to update some copy from the current default templates provided.

This updates the `single` template copy as it's needed to clear up the ambiguity between the single template that is the fallback for any custom post type (including `post`) and the menu item to be added in a subsequent commit, that will allow the creation the `single-post` template and any `single_$post_type` template.

This commit backports the original PR from Gutenberg repository:
* [WordPress/gutenberg#41302 #41302: Site Editor: Update single default template copy]

Follow-up to [52062], [52331].

Props ntsekouras, bernhard-reiter, jameskoster, Mamaduka, scruffian.
Fixes #56534.
Built from https://develop.svn.wordpress.org/trunk@54104
ootwch pushed a commit to ootwch/wordpress-develop that referenced this pull request Nov 4, 2022
In order to add more template types we need to update some copy from the current default templates provided.

This updates the `single` template copy as it's needed to clear up the ambiguity between the single template that is the fallback for any custom post type (including `post`) and the menu item to be added in a subsequent commit, that will allow the creation the `single-post` template and any `single_$post_type` template.

This commit backports the original PR from Gutenberg repository:
* [WordPress/gutenberg#41302 #41302: Site Editor: Update single default template copy]

Follow-up to [52062], [52331].

Props ntsekouras, bernhard-reiter, jameskoster, Mamaduka, scruffian.
Fixes #56534.

git-svn-id: https://develop.svn.wordpress.org/trunk@54104 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs User Documentation Needs new user documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants