Reorganize global styles menu #41574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcanales
added
Global Styles
2 tasks
|
Size Change: +200 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
critterverse
requested changes
Jun 7, 2022
There was a problem hiding this comment.
Nice! This feels so easy to read and navigate. Curious to hear from @pablohoneyhoney and others who have done a lot of work on the Global Styles panel about whether this seems like the right (small, incremental) next step towards simplifying the panel — especially before potentially adding more items there.
One small note that we don't need the divider line after the "Blocks" item.
Done!
|
vcanales
force-pushed
the
try/reorganize-panel
branch
from
b2ffa64 to
a4d8ac0
Compare
|
Nice. Pinging @WordPress/gutenberg-design to get some more eyes on this! |
Cool! Looking forward to a decision! |
added 2 commits
June 16, 2022 14:03
Implements the second alternative shown in #40478 to reorganize the Global Styles panel to keep both Blocks and Browse styles links in line with the rest of the menu. Let's iterate over this PR to decide on which of the two options makes more sense.
vcanales
force-pushed
the
try/reorganize-panel
branch
from
a4d8ac0 to
53dde69
Compare
|
I find it weird to have "Browse styles" between Layout and Blocks. Those two items have more things in common than the "Browse style" one, so I think they should be together. I think the other alternative in #40478 makes more sense and would be easier to scan and use: Browse styles Typography |
|
I agree that the order doesn't feel quite right. As I understand it Styles are essentially preset configurations for block, layout, typography, and color, and so exist a layer above those areas. Perhaps not something to figure out here, but I find it a little strange to find a "Styles" section within the "Styles" panel. |
|
I missed the original issue that sparked it, but this iteration seems to mix the information architecture in ways that are more confusing. It's important to keep the Blocks panel separate from the style elements, and the "browse styles" exists at an entirely different level. This design fails to communicate this in any meaningful way. |
|
@vcanales I think we could close this PR based on the feedback above and revisit this with a reconsidered design approach. |
Closing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the second alternative shown in #40478
to reorganize the Global Styles panel to keep both Blocks and Browse
styles links in line with the rest of the menu.
Let's iterate over this PR to decide on which of the two options makes
more sense.
Preview