Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate spacer test to playwright #41590

Merged
merged 10 commits into from
Jun 20, 2022

Conversation

miminari
Copy link
Member

@miminari miminari commented Jun 8, 2022

What?

Migrate spacer.test.js to its Playwright version.

Why?

See #38570 for its background and rationale.

How?

See MIGRATION.md for migration steps.

Testing Instructions

Run npm run test-e2e:playwright -- /test/e2e/specs/editor/blocks/spacer.spec.js.

related #38851

@miminari miminari requested review from talldan and kevin940726 and removed request for talldan and kevin940726 June 8, 2022 02:59
@miminari miminari added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Jun 8, 2022
@miminari miminari requested review from kevin940726 and talldan June 8, 2022 03:17
Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some suggestions regarding code quality. Overall it looks good!

test/e2e/specs/editor/blocks/spacer.spec.js Outdated Show resolved Hide resolved
test/e2e/specs/editor/blocks/spacer.spec.js Outdated Show resolved Hide resolved
Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Just a small nitpick left. Sorry for the late review!

test/e2e/specs/editor/blocks/spacer.spec.js Outdated Show resolved Hide resolved
Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rephrased the comment a little bit, hope you don't mind!

test/e2e/specs/editor/blocks/spacer.spec.js Outdated Show resolved Hide resolved
Co-authored-by: Kai Hao <kevin830726@gmail.com>
@talldan talldan merged commit aadaab5 into WordPress:trunk Jun 20, 2022
@github-actions github-actions bot added this to the Gutenberg 13.6 milestone Jun 20, 2022
@miminari miminari deleted the migrate/playwright-spacer branch July 23, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants