-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate spacer test to playwright #41590
Migrate spacer test to playwright #41590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left some suggestions regarding code quality. Overall it looks good!
packages/e2e-test-utils-playwright/src/editor/drag-and-resize.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Just a small nitpick left. Sorry for the late review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rephrased the comment a little bit, hope you don't mind!
Co-authored-by: Kai Hao <kevin830726@gmail.com>
What?
Migrate spacer.test.js to its Playwright version.
Why?
See #38570 for its background and rationale.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run npm run test-e2e:playwright -- /test/e2e/specs/editor/blocks/spacer.spec.js.
related #38851