Comment Author and Date blocks: aligned editor markup with the frontend #41631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
cbravobernal
added
[Block] Comment Author
ockham
added
the
Backport to WP Minor Release
This was referenced Jun 10, 2022
adamziel
pushed a commit
that referenced
this pull request
Jun 21, 2022
|
I just cherry-picked this PR to the wp/6.0 branch to get it included in the next release: 3eb218f |
adamziel
removed
the
Backport to WP Minor Release
mburridge
added
the
Needs Dev Note
|
Added the Needs Dev Note label in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #41621 for the Comment Author block and the Comment date block
Co-created with @c4rl0sbr4v0
Why?
The markup on the frontend and the editor are not the same and that causes discrepancies of styling (in this case because of the margin the editor adds to p tags).
How?
I changed the markup in the editor to be like what's on the frontend. Maybe we should make them also look like links in the editor when no comment ID is present? so that the link styles are also visible on the editor, but I'd prefer that we discuss that since it seemed a bit more involved than this change.
Testing Instructions
I tested with Blockbase theme.
Screenshots or screencast
Before:
After: