[Mobile] Add react-native-fast-image #42009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Status] In Progress
2 tasks
|
Size Change: -91 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
3 tasks
geriux
force-pushed
the
rnmobile/add/react-native-fast-image
branch
from
caf8801 to
ca0b409
Compare
4 tasks
added 2 commits
July 7, 2022 15:14
# Conflicts: # packages/react-native-editor/CHANGELOG.md
added 3 commits
July 11, 2022 11:58
# Conflicts: # packages/react-native-editor/ios/Podfile.lock
6 tasks
4 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Gutenberg Mobile PR-> Add react-native-fast-image wordpress-mobile/gutenberg-mobile#4989WordPress Android PR-> [Gutenberg] Add react-native-fast-image wordpress-mobile/WordPress-Android#16832WordPress iOS PR-> [Gutenberg] Add React Native FastImage wordpress-mobile/WordPress-iOS#18995What?
This PR adds the React Native FastImage library that improves the performance of image rendering in the editor.
Note: There are other changes needed to improve the performance even more with the following PR #42178.
Why?
The goal is to improve the performance of the editor when there are images (Gallery, and Image blocks). The React Native FastImage library uses Glide (Android) and SDWebImage (iOS) so it helps with rendering and memory usage.
How?
By replacing the built-in Image from React Native and using FastImage instead:
Testing Instructions
Note: Test with both the demo app and the WordPress apps using the builds from the PRs linked above.
Test case 1 - Image block
Test case 2 - Gallery block
Screenshots or screencast
Test case 1 - Image block
AndroidImageBlock.mov
Test case 2 - Gallery block
Android.mov