Post Template: Fix condition checks #42038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Document Settings
|
Size Change: +6 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
Aha, yep, you're right. Looks like while copying the old logic I misunderstood this condition: And missed this condition: |
|
How hard would it be to add E2E tests for the three scenarios you identified? |
|
For some reason I thought Twenty Twenty-one was a classic theme that had
One problem I noticed when checking Kadence is that you have to refresh the editor after creating a block template in order for the Default template option to appear. It looks like this bug existed before #41925 though (I verified by disabling Gutenberg) so it's not relevant to this PR. |
noisysocks
approved these changes
Jun 30, 2022
Technically not complicated, but I'm worried that switching between multiple themes for simple tests might be flaky. Adding this to my to-do list and will try to follow up with e2e tests shortly.
Correct, the "Default template" string is supplied by the server, so it requires a page refresh. Maybe we can fix this as a part of #41449. |
|
I'm going to merge this. @jorgefilipecosta, we'll need to cherry-pick this for the next release. |
|
Thanks @Mamaduka! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A follow-up to #41925.
PR fixes the following conditions for the "Post Template" component:
Why?
These match behavior of the previous Post Template panel component.
P.S. @noisysocks, sorry I missed this during initial testing.
Testing Instructions
Theme with no templates
Theme with templates, no block template support
Block Theme
Screenshots or screencast