Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] RichText: Prevent early return in onSelectionChangeFromAztec when content has leading or trailing spaces #42046

Closed
wants to merge 5 commits into from
Closed

[RNMobile] RichText: Prevent early return in onSelectionChangeFromAztec when content has leading or trailing spaces #42046

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98639da
Detect if space is used at start or end of string
Jun 29, 2022
8db0d5f
Update variable name for clarity/conciseness
Jun 29, 2022
bc1b494
Add missing space in leadingOrTrailingSpace check
Jun 29, 2022
8354b80
Add clarifying comment
Jun 29, 2022
117288e
Add further clarification to comment
Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/rich-text/src/component/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,9 +659,16 @@ export class RichText extends Component {

// Check for and discard events during quick typing. Updating the selection during quick typing isn't
// necessary and can cause UI lags. (see https://github.com/WordPress/gutenberg/pull/41682.)
// Note, it's necessary to detect leading or trailing spaces to prevent them from being stripped.
// (see https://github.com/WordPress/gutenberg/pull/42046.)
const leadingOrTrailingSpace =
contentWithoutRootTag.charAt( 0 ) === ' ' ||
contentWithoutRootTag.substr( contentWithoutRootTag.length - 1 ) ===
' ';
if (
contentWithoutRootTag !== this.value &&
this.lastAztecEventType === 'selection change'
this.lastAztecEventType === 'selection change' &&
! leadingOrTrailingSpace
) {
return;
}
Expand Down