Add aria-checked to the selected heading level menu item. #42273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: +19 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
@afercia While we are still on the subject, do you think there are other blocks that suffer from this issue? Might be worth checking which blocks are using this component and maybe look in to changing the component defaults. Looks like it is using ToolbarDropdownMenu. |
|
Thanks @alexstine. All the occurrences of |
|
about ancestor, there is already an ongoing issue/PR #40778 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In the heading level dropdown menu, the selected heading level is highlighted only visually. There's no semantics to indicate its 'selected' state.
Additionally, this menu provides a single choice: only one level can be selected at a time. A role of
menuitemradiois more appropriate than the genericmenuitem.Why?
When screen reader users navigate through the heading level items, they don't have a clue what the selected one is.
How?
Passing a prop
role: 'menuitemradio'fixes the semantics. When the menu item component has this role, it also automatically handles thearia-checkedattribute, which provides the necessary information on the selected heading level.Testing Instructions
role="menuitemradio"attribute.aria-checked="true"attribute.aria-checked="false"attribute.Screenshots or screencast