Documentation: Consolidate editor filters and actions #42356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
the
[Feature] Extensibility
aristath
approved these changes
Jul 12, 2022
|
I love the idea of having them in the same doc as |
gziolo
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
It was only a draft because I was still compiling the description 😄 |
gziolo
commented
Jul 12, 2022
| ### Block Directory | ||
| ## Logging errors | ||
|
|
||
| A JavaScript error in a part of the UI shouldn’t break the whole app. To solve this problem for users, React library uses a concept of an [“error boundary”](https://reactjs.org/docs/error-boundaries.html). Error boundaries are React components that catch JavaScript errors anywhere in their child component tree, and display a fallback UI instead of the component tree that crashed. |
There was a problem hiding this comment.
The brief background about Error Boundaries in React really helps give some useful context before hoping into the hook! 👍🏻
gziolo
commented
Jul 18, 2022
gziolo
commented
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up for #42024.
All sections covering WordPress hooks in Block Editor Handbook are wrongly referencing filters. It should be "hooks" as we use both filters and actions.
Why?
This is also how documentation is structured for WordPress core. See https://developer.wordpress.org/plugins/hooks/.
How?
This PR tries to address the issue partially by renaming those documents that cover both filters and action. I didn't change URLs because it would require some bigger changes like updating all references to those pages and adding HTTP redirects so all external URLs continue to work.
Finally, I moved the section about Error Boundaries from the editor actions document that was disconnected from Block Editor Handbook to the one that previously covered only editor filters.