WP_HTML_Tag_Processor: Inject dynamic data to block HTML markup in PHP #42485
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| <?php | ||
| /** | ||
| * HTML Tag Processor: Attribute token structure class. | ||
| * | ||
| * @package WordPress | ||
| * @subpackage HTML | ||
| * @since 6.1.0 | ||
| */ | ||
|
|
||
| /** | ||
| * Data structure for the attribute token that allows to drastically improve performance. | ||
| * | ||
| * This class is for internal usage of the WP_HTML_Tag_Processor class. | ||
| * | ||
| * @access private | ||
| * @since 6.1.0 | ||
adamziel marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * | ||
| * @see WP_HTML_Tag_Processor | ||
| */ | ||
| class WP_HTML_Attribute_Token { | ||
|
There was a problem hiding this comment. Please lock down this code so it is not accessible from plugins or other parts of WordPress. It should only be used for the cases described in this PR. |
||
| /** | ||
| * Attribute name. | ||
| * | ||
| * @since 6.1.0 | ||
| * @var string | ||
| */ | ||
| public $name; | ||
|
|
||
| /** | ||
| * Attribute value. | ||
| * | ||
| * @since 6.1.0 | ||
| * @var int | ||
| */ | ||
| public $value_starts_at; | ||
|
|
||
| /** | ||
| * How many bytes the value occupies in the input HTML. | ||
| * | ||
| * @since 6.1.0 | ||
| * @var int | ||
| */ | ||
| public $value_length; | ||
|
|
||
| /** | ||
| * The string offset where the attribute name starts. | ||
| * | ||
| * @since 6.1.0 | ||
| * @var int | ||
| */ | ||
| public $start; | ||
|
|
||
| /** | ||
| * The string offset after the attribute value or its name. | ||
| * | ||
| * @since 6.1.0 | ||
| * @var int | ||
| */ | ||
| public $end; | ||
|
|
||
| /** | ||
| * Whether the attribute is a boolean attribute with value `true`. | ||
| * | ||
| * @since 6.1.0 | ||
| * @var bool | ||
| */ | ||
| public $is_true; | ||
|
|
||
| /** | ||
| * Constructor. | ||
| * | ||
| * @since 6.1.0 | ||
| * | ||
| * @param string $name Attribute name. | ||
| * @param int $value_start Attribute value. | ||
| * @param int $value_length Number of bytes attribute value spans. | ||
| * @param int $start The string offset where the attribute name starts. | ||
| * @param int $end The string offset after the attribute value or its name. | ||
| * @param bool $is_true Whether the attribute is a boolean attribute with true value. | ||
| */ | ||
| public function __construct( $name, $value_start, $value_length, $start, $end, $is_true ) { | ||
| $this->name = $name; | ||
| $this->value_starts_at = $value_start; | ||
| $this->value_length = $value_length; | ||
| $this->start = $start; | ||
| $this->end = $end; | ||
| $this->is_true = $is_true; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamziel and @dmsnell, is the note about the performance implications valid? Should we also include the same note for
WP_Class_Name_UpdateandWP_Text_Replacement? I know you discussed that extensively, but I'm not sure which part made the biggest difference.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is valid, I think in @dmsnell's testing it reduced memory usage by like 90% compared to
array()which sounds almost unbelievable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we can update these comments across the board.
array()was surprisingly terribly inefficient with memory use.