Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blocks] Paragraph and Heading: add gradient support #43119

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

MaggieCabrera
Copy link
Contributor

@MaggieCabrera MaggieCabrera commented Aug 10, 2022

What?

Adds gradient supports for paragraph and heading blocks
Closes #30982
Part of #41113

Why?

Before we had a way to hide block settings from the sidebar we had to be careful about what we were exposing in the UI, that is not the case anymore and we can add supports as users need them more freely without fearing UI clutter.

How?

Just added the support to block.json :D

Testing Instructions

Open the editor and change the background of the block to a gradient! Then check the frontend too.

Screenshots or screencast

Tested on emptytheme:

Screen Capture on 2022-08-10 at 15-17-14

/cc @WordPress/block-themers

@MaggieCabrera MaggieCabrera self-assigned this Aug 10, 2022
@MaggieCabrera MaggieCabrera added the [Block] Paragraph Affects the Paragraph Block label Aug 10, 2022
@MaggieCabrera MaggieCabrera changed the title add gradient support to paragraph block [Blocks] Paragraph: add gradient support Aug 10, 2022
@bgardner
Copy link

Considering the option for Gradient exists with the Code, Pullquote, and Quote blocks, this makes sense (and moves us closer to overall block settings consistency).

Copy link
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@briceduclos
Copy link

@MaggieCabrera Thanks! It would be great also to add gradient support to the Heading block.

@carolinan
Copy link
Contributor

Maybe we can keep the issue open and update the title because I would hate to loose the suggestion for gradient texts 😆

@MaggieCabrera
Copy link
Contributor Author

There you go!

Screenshot 2022-08-11 at 09 21 48

@MaggieCabrera MaggieCabrera changed the title [Blocks] Paragraph: add gradient support [Blocks] Paragraph and Heading: add gradient support Aug 11, 2022
@scruffian scruffian merged commit 2cc282a into trunk Aug 11, 2022
@scruffian scruffian deleted the paragraph-gradient-support branch August 11, 2022 09:30
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 11, 2022
@bph bph added the Needs Dev Note Requires a developer note for a major WordPress release cycle label Aug 11, 2022
@bph
Copy link
Contributor

bph commented Aug 11, 2022

Added label needs dev note to add it to a list of other changes for enabling and disabling features in block.json / theme.json.

@bph bph added the Needs User Documentation Needs new user documentation label Aug 11, 2022
@bgardner
Copy link

@carolinan Gradient texts... like so? https://bg.design/bright-mode/

@MaggieCabrera
Copy link
Contributor Author

@carolinan Gradient texts... like so? https://bg.design/bright-mode/

Like #30982

Right now we are checking for accesibility issues with text colors, right? For text gradients it would be the same, but testing all the colors involved in the gradient, am I right?

@femkreations femkreations removed the Needs User Documentation Needs new user documentation label Sep 4, 2022
@bph bph mentioned this pull request Oct 3, 2022
89 tasks
@bph bph removed the Needs Dev Note Requires a developer note for a major WordPress release cycle label Oct 11, 2022
@bph
Copy link
Contributor

bph commented Oct 11, 2022

removed needs dev note - as it's only a UI change. Disabling duotone is already available in 6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Paragraph Affects the Paragraph Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add gradient support to the paragraph TEXT
7 participants