Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media & Text: Add typography support #43314

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds all typography support to the Media & Text block.

Why?

  • Improves consistency of our design tools across blocks.
  • Provides a means of applying typographic styles across multiple inner blocks for Media & Text.

How?

  • Opts into all typography support.
  • Makes the font size control display by default.

Testing Instructions

  1. Edit a post, add a List block with multiple items, and select an item.
  2. Test various typography settings ensuring styles are applied in the editor.
  3. Save and confirm the application on the frontend.
  4. Switch to the site editor and add a List with items to a page or template.
  5. Navigate to Global Styles > Blocks > Media & Text > Typography and apply typography styles there.
  6. Confirm the selected styles are reflected in the preview and on the frontend.

Screenshots or screencast

Screen.Recording.2022-08-17.at.7.16.15.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Media & Text Affects the Media & Text Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs labels Aug 17, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 17, 2022
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generally working well for me, but it looks like there's a similar issue with the typography settings affecting the image placeholder components, much like with the Cover block:

image

As discussed on the other PR, since we decided not to let that block the Cover opt-ins from landing, I don't think it should be a blocker here, either.

✅ Individual controls are otherwise testing well for all properties in the post editor at the individual block level
✅ Each of the controls exposed in global styles are otherwise working correctly in the site editor and reflected on the site frontend

LGTM! ✨

@aaronrobertshaw
Copy link
Contributor Author

Thanks for the review @andrewserong.

looks like there's a similar issue with the typography settings affecting the image placeholder components, much like with the Cover block:

I already had this under the "Known issues" section of the typography tracking issue. I've also added it now under a "Planned follow-ups" section to make it clearer it will be addressed but in a more holistic way. I hope this afternoon or tomorrow to put up a PR addressing it.

@aaronrobertshaw aaronrobertshaw merged commit 112305c into trunk Aug 22, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/typography-support-to-media-text branch August 22, 2022 03:04
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 22, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Media & Text Affects the Media & Text Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants