-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacer: add spacing block supports #43366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is working except for the theme.json code. Can you double check that is working for you? The styles did not seem to apply on the front end for me.
Appears that the individual margin sides at the theme.json block level are a known curiosity: #43365 (comment) Given that things work in the editor for block supports, which is the major thrust of these PRs, do folks think it's okay to allow support here and address the universal issue elsewhere? |
Yes sounds good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked as advertised for me in editor and front-end. Agree that we should merge this and look at the theme.json issue in follow ups.
Related:
What?
Enabling axial margin support for the spacer block.
Why?
To create consistency across blocks.
How?
Adding the relevant block supports in block.json
Testing Instructions
2022-08-18.19.50.22.mp4