Editor: Refactor a few component tests to @testing-library/react
#43376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
Size Change: +1.33 kB (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
LGTM 🚀
Just a nit: when we're asserting for an element to be in the document / visible, we could use getBy... queries instead of queryBy... , since the getBy... explicitly throw when the element is not found.
It wouldn't make a difference in this PR, so it's mostly a convention / stylistic choice — up to you!
Updated in 5f4497a, happy to keep things consistent. I can't stop wondering though, how is that useful, considering that using |
|
I don't feel super strongly about it to be honest, but the general recommendation given by Kent is to only use |
Ah, I was looking for that, thanks @mirka 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We've recently started refactoring
enzymetests to@testing-library/react.This PR refactors a few of the simpler editor component tests from
enzymeto@testing-library/react. I've specifically picked the most straightforward ones that boil down to "should render" or "should not render".Why?
@testing-library/reactprovides a better way to write tests for accessible components that is closer to the way the user experiences them.How?
We're straightforwardly replacing
enzymetests with@testing-library/reactones, usingjest-dommatches and screen queries.Testing Instructions
Verify tests pass:
npm run test:unit packages/editor/src/components