Added unit test for post excerpt block render function #43451

akasunil · 2022-08-21T05:37:50Z

What?

Added unit test for Post excerpt core block render function.

…ender

akasunil · 2022-11-14T04:41:08Z

@draganescu Can you please review this PR ?

…ender

akasunil · 2023-01-02T05:23:30Z

waiting for PR review

anton-vlasenko

I've reviewed this PR. You can find my notes below.
Thanks!

phpunit/blocks/render-block-post-excerpt-test.php

anton-vlasenko · 2023-01-04T17:46:24Z

phpunit/blocks/render-block-post-excerpt-test.php

+		$block = new stdClass();
+
+		// call render method with block context.
+		$rendered = gutenberg_render_block_core_Post_Excerpt( self::$attributes, '', $block );


Suggested change

$rendered = gutenberg_render_block_core_Post_Excerpt( self::$attributes, '', $block );

$rendered = gutenberg_render_block_core_post_excerpt( self::$attributes, '', $block );

Why does this function use capital letters in its name?
Is it a typo?

anton-vlasenko · 2023-01-04T17:46:43Z

phpunit/blocks/render-block-post-excerpt-test.php

+		$this->assertEmpty( $rendered );
+
+		$block->context = array( 'postId' => 0 );
+		$rendered       = gutenberg_render_block_core_Post_Excerpt( self::$attributes, '', $block );


anton-vlasenko · 2023-01-04T17:48:21Z

phpunit/blocks/render-block-post-excerpt-test.php

+	}
+
+	/**
+	 * Test gutenberg_render_block_core_Post_Excerpt() method


anton-vlasenko · 2023-01-04T17:52:55Z

phpunit/blocks/render-block-post-excerpt-test.php

+		$block->context  = array( 'postId' => self::$post_empty->ID );
+
+		$rendered = gutenberg_render_block_core_post_excerpt( self::$attributes, '', $block );
+		$this->assertEmpty( $rendered );


When a test method contains more than 1 assertion, a failure message should be added to the assertion method.
Please see https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#using-assertions

anton-vlasenko · 2023-01-04T17:58:16Z

phpunit/blocks/render-block-post-excerpt-test.php

+
+		$rendered = gutenberg_render_block_core_post_excerpt( self::$attributes, '', $block );
+		$this->assertNotEmpty( $rendered );
+		$this->assertStringContainsString( 'Post Expert content', $rendered );


Please add failure messages.

…ender

akasunil · 2023-04-27T11:47:46Z

@anton-vlasenko Feedback addressed. Can you please review it again.

… add-test-for-post-excerpt-block-render

github-actions · 2024-02-26T06:42:26Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: anton-vlasenko <antonvlasenko@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

anton-vlasenko

https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#test-classes

Test files should be named using camelCase.

phpunit/blocks/render-block-post-excerpt-test.php

… add-test-for-post-excerpt-block-render

akasunil · 2024-04-28T08:35:32Z

I have updated phpunit config temporary until we change all filenames to camel case as per wordpress core standard. And Addressed all feedback provided by reviewer.

anton-vlasenko

These comments are mostly minor (sorry for being so meticulous). Thank you for considering my review.

anton-vlasenko · 2024-05-08T22:37:59Z

phpunit/blocks/renderBlockCorePostExcerpt.php

+	protected static $post;
+
+	/**
+	 * Array of Attributes.


Suggested change

* Array of Attributes.

* Array of attributes.

phpunit/blocks/renderBlockCorePostExcerpt.php

akasunil · 2024-05-09T06:10:52Z

@anton-vlasenko I have addressed your feedbacks.

anton-vlasenko

Since each test method initializes the $block variable, I think it could be moved to the set_up() method.
However, I don't think this should be a blocker.
LGTM.

akasunil · 2024-05-22T05:10:16Z

Can we merge this PR ?

akasunil · 2024-05-24T13:51:05Z

@draganescu if you have space, can you review this PR too #42435

anton-vlasenko · 2024-05-24T21:10:10Z

Can we merge this PR ?

I apologize for assuming you could merge it yourself.
I'm glad to see it has been merged now.

akasunil · 2024-05-25T05:08:16Z

I apologize for assuming you could merge it yourself.

No worries

* Added unittest for post excerpt block render function * Updated wpSetUpBeforeClass method with argument * Addressed feedbacks * fix unit test failure * Fix coding standards * Fix phpcs issue * Update config to allow files with new name standard * Change test file name to camel case * Update assertion comments and formatting --------- Co-authored-by: Sunil Prajapati <61308756+sunil25393@users.noreply.github.com> Co-authored-by: akasunil <sunil25393@git.wordpress.org> Co-authored-by: anton-vlasenko <antonvlasenko@git.wordpress.org>

akasunil and others added 3 commits August 21, 2022 11:00

Added unittest for post excerpt block render function

731a3d0

Merge branch 'WordPress:trunk' into add-test-for-post-excerpt-block-r…

e01cf0f

…ender

Merge branch 'WordPress:trunk' into add-test-for-post-excerpt-block-r…

c40b9a6

…ender

akasunil and others added 3 commits November 17, 2022 10:21

Merge branch 'WordPress:trunk' into add-test-for-post-excerpt-block-r…

d60295d

…ender

Merge branch 'WordPress:trunk' into add-test-for-post-excerpt-block-r…

d90e259

…ender

Updated wpSetUpBeforeClass method with argument

4f4d8f3

anton-vlasenko reviewed Jan 4, 2023

View reviewed changes

draganescu changed the title ~~Added unittest for post excerpt block render function~~ Added unit test for post excerpt block render function Jan 6, 2023

akasunil and others added 2 commits January 10, 2023 11:12

Merge branch 'WordPress:trunk' into add-test-for-post-excerpt-block-r…

37055e3

…ender

Addressed feedbacks

3f70944

akasunil requested a review from anton-vlasenko January 28, 2023 15:57

skorasaurus added the [Block] Post Excerpt Affects the Post Excerpt Block label Apr 10, 2023

This comment was marked as outdated.

Sign in to view

Merge branch 'trunk' of personal.github.com:sunil25393/gutenberg into…

d9ac6f6

… add-test-for-post-excerpt-block-render

fix unit test failure

9d5e984

akasunil requested a review from anton-vlasenko February 26, 2024 07:02

akasunil added 2 commits February 27, 2024 10:42

Fix coding standards

ebd1fdf

Fix phpcs issue

c9b2f0f

anton-vlasenko reviewed Mar 5, 2024

View reviewed changes

phpunit/blocks/render-block-post-excerpt-test.php Outdated Show resolved Hide resolved

phpunit/blocks/render-block-post-excerpt-test.php Outdated Show resolved Hide resolved

phpunit/blocks/render-block-post-excerpt-test.php Outdated Show resolved Hide resolved

Merge branch 'trunk' of personal.github.com:sunil25393/gutenberg into…

876966b

… add-test-for-post-excerpt-block-render

youknowriad removed the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Apr 3, 2024

akasunil marked this pull request as draft April 19, 2024 08:55

akasunil added 3 commits April 28, 2024 13:53

Merge branch 'trunk' of personal.github.com:sunil25393/gutenberg into…

9cbe351

… add-test-for-post-excerpt-block-render

Update config to allow files with new name standard

ffefb68

Change test file name to camel case

4dd1212

akasunil marked this pull request as ready for review April 28, 2024 08:35

anton-vlasenko reviewed May 8, 2024

View reviewed changes

Update assertion comments and formatting

c1b8d75

anton-vlasenko approved these changes May 9, 2024

View reviewed changes

draganescu merged commit 7988696 into WordPress:trunk May 24, 2024
60 checks passed

github-actions bot added this to the Gutenberg 18.5 milestone May 24, 2024

akasunil deleted the add-test-for-post-excerpt-block-render branch May 24, 2024 13:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added unit test for post excerpt block render function #43451

Added unit test for post excerpt block render function #43451

akasunil commented Aug 21, 2022

akasunil commented Nov 14, 2022

akasunil commented Jan 2, 2023

anton-vlasenko left a comment

anton-vlasenko Jan 4, 2023

anton-vlasenko Jan 4, 2023

anton-vlasenko Jan 4, 2023

anton-vlasenko Jan 4, 2023

anton-vlasenko Jan 4, 2023

akasunil commented Apr 27, 2023

This comment was marked as outdated.

github-actions bot commented Feb 26, 2024 •

edited

Loading

anton-vlasenko left a comment

akasunil commented Apr 28, 2024

anton-vlasenko left a comment

anton-vlasenko May 8, 2024

akasunil commented May 9, 2024

anton-vlasenko left a comment

akasunil commented May 22, 2024

akasunil commented May 24, 2024

anton-vlasenko commented May 24, 2024

akasunil commented May 25, 2024

	$rendered = gutenberg_render_block_core_Post_Excerpt( self::$attributes, '', $block );
	$rendered = gutenberg_render_block_core_post_excerpt( self::$attributes, '', $block );

Added unit test for post excerpt block render function #43451

Added unit test for post excerpt block render function #43451

Conversation

akasunil commented Aug 21, 2022

What?

akasunil commented Nov 14, 2022

akasunil commented Jan 2, 2023

anton-vlasenko left a comment

Choose a reason for hiding this comment

anton-vlasenko Jan 4, 2023

Choose a reason for hiding this comment

anton-vlasenko Jan 4, 2023

Choose a reason for hiding this comment

anton-vlasenko Jan 4, 2023

Choose a reason for hiding this comment

anton-vlasenko Jan 4, 2023

Choose a reason for hiding this comment

anton-vlasenko Jan 4, 2023

Choose a reason for hiding this comment

akasunil commented Apr 27, 2023

This comment was marked as outdated.

github-actions bot commented Feb 26, 2024 • edited Loading

anton-vlasenko left a comment

Choose a reason for hiding this comment

akasunil commented Apr 28, 2024

anton-vlasenko left a comment

Choose a reason for hiding this comment

anton-vlasenko May 8, 2024

Choose a reason for hiding this comment

akasunil commented May 9, 2024

anton-vlasenko left a comment

Choose a reason for hiding this comment

akasunil commented May 22, 2024

akasunil commented May 24, 2024

anton-vlasenko commented May 24, 2024

akasunil commented May 25, 2024

github-actions bot commented Feb 26, 2024 •

edited

Loading