DateTimePicker: address feedback after recent refactor to date-fns and use-lilius
#43495
+54
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Feature] Document Settings
|
Size Change: +140 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Thank you for addressing the feedback, @noisysocks !
Feel free to merge this PR after:
- adding an
eslint-disablecomment as requested in DateTimePicker: Replace react-dates and moment with useLilius and date-fns #43005 (comment) - adding the line-height rule to the day of week element (see
DateTimePicker: address feedback after recent refactor todate-fnsanduse-lilius#43495 (comment)) - adding an inline comment for the
stringthe type cast (seeDateTimePicker: address feedback after recent refactor todate-fnsanduse-lilius#43495 (comment)) - (optionally) addressing the feedback from DateTimePicker: Replace react-dates and moment with useLilius and date-fns #43005 (comment)
- adding a CHANGELOG entry
ciampo
changed the title
DateTimePicker feedbackDateTimePicker: address feedback after recent refactor to date-fns and use-lilius
ciampo
reviewed
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #43005. Addresses some additional feedback left in #43005 (review). See the original PR for background on these changes and testing instructions.