Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: Make menu and title labels in Gutenberg plugin translatable #43500

Merged
merged 2 commits into from
Dec 22, 2023
Merged

i18n: Make menu and title labels in Gutenberg plugin translatable #43500

merged 2 commits into from
Dec 22, 2023

Conversation

mhimon
Copy link
Contributor

@mhimon mhimon commented Aug 23, 2022 •
edited
Loading

Added translation to Page Title.

@mhimon mhimon requested a review from spacedmonkey as a code owner August 23, 2022 05:41
@ndiego
Copy link
Member

ndiego commented Aug 23, 2022

@mhimon can you provide a description to this PR?

@mhimon
Copy link
Contributor Author

mhimon commented Aug 24, 2022

@mhimon can you provide a description to this PR?

Added. Thanks

@t-hamano
Copy link
Contributor

t-hamano commented Dec 20, 2022 •
edited
Loading

Hi @mhimon,

Do you mean you want the menu labels in the Gutenberg plugin to be translatable? Then it would be a good idea to make the first argument, $page_title, translatable as well.

Note that the plugin label change was also suggested in #8074.

@mhimon
Copy link
Contributor Author

mhimon commented Dec 20, 2022

Updated! Thanks.

@t-hamano t-hamano changed the title Updated Page Title i18n: Make menu and title labels in Gutenberg plugin translatable Dec 20, 2022
@t-hamano t-hamano added Internationalization (i18n) Issues or PRs related to internationalization efforts Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Dec 20, 2022
@t-hamano
Copy link
Contributor

@mhimon Sorry for the delay in re-checking this PR. Could you rebase with the latest trunk in order to merge this PR? That way, GitHub Actions that are stopped will be re-run.

mhimon added a commit to mhimon/gutenberg that referenced this pull request Dec 22, 2023
@mhimon
WordPress#43500 Update init.php
c9b5836
@t-hamano t-hamano closed this Dec 22, 2023
@t-hamano t-hamano reopened this Dec 22, 2023
@t-hamano t-hamano self-requested a review December 22, 2023 11:36
@t-hamano t-hamano added the [Type] Code Quality Issues or PRs that relate to code quality label Dec 22, 2023
t-hamano
t-hamano approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After closing and reopening this PR, GitHub Action seems to have started working again. I think this change makes sense and I would like to merge it after it passes all tests.

Thanks for your contribution!

@t-hamano t-hamano merged commit ebb171b into WordPress:trunk Dec 22, 2023
53 of 54 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.4 milestone Dec 22, 2023
@getdave getdave added the Needs PHP backport Needs PHP backport to Core label Jan 15, 2024
@getdave getdave mentioned this pull request Jan 18, 2024
Closed
@getdave getdave removed the Needs PHP backport Needs PHP backport to Core label Jan 23, 2024
@getdave
Copy link
Contributor

getdave commented Jan 23, 2024

✅ I updated the PHP Sync Tracking Issue for WP 6.5 to note this PR does not require a backport for WP 6.5.

It only changes the menu item for the Gutenberg Plugin and thus is unused in WP Core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees
No one assigned
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 17.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mhimon @ndiego @t-hamano @getdave