ColorPalette: Make popover style consistent #43570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
commented
Aug 24, 2022
| @@ -31,20 +31,6 @@ | |||
| } | |||
| } | |||
|
|
|||
| .components-dropdown__content.components-color-palette__custom-color-dropdown-content .components-popover__content { | |||
| overflow: visible; | |||
There was a problem hiding this comment.
This was already being overridden by an inline style that sets overflow: auto.
Comment on lines
-42
to
-45
| .react-colorful__saturation { | ||
| border-top-right-radius: $radius-block-ui; | ||
| border-top-left-radius: $radius-block-ui; | ||
| } |
There was a problem hiding this comment.
Removed because this is only necessary when overflow: visible.
|
Size Change: -117 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
mirka
force-pushed
the
color-palette-styles
branch
from
cf8bdb9 to
048c509
Compare
|
Thanks for working on this, it's working as advertised for me. While we're here, it might be nice to make the panels the same width, assuming it's not too much work? If so, we can tackle it later :) |
It looks like the ColorPicker width is pretty tightly hardcoded, so let's tackle it separately 👍 (Also relevant: We're planning on reducing the circular swatch size from 28px to a consistent 20px soon.) |
jameskoster
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41787
What?
Make the ColorPalette popover styles consistent with the other standard popovers. Namely, the border and the shadow styles.
Why?
For consistency.
How?
Remove overrides and use the
DropdownContentWrapperto remove paddings.Testing Instructions
npm run storybook:devand see the ColorPalette story.Screenshots or screencast
Here's a screenshot of it side-by-side with the ColorGradientControl: